shadow: Redo shadow implementation for rotations

The shadows went bonkers when the labels were rotated

diff --git a/gtk/gtkshadow.c b/gtk/gtkshadow.c
index 89702c0a3f3ce719eb9c7ba1701f2e2d77abe9f2..f1f58c8f8ba29a4560c6540aa7dca3a07c7b38a2 100644 (file)
--- a/gtk/gtkshadow.c
+++ b/gtk/gtkshadow.c
@@ -258,13 +258,14 @@ _gtk_shadow_to_string (GtkShadow *shadow)
 void
 _gtk_text_shadow_paint_layout (GtkShadow       *shadow,
                                cairo_t         *cr,
-                               gdouble          x,
-                               gdouble          y,
                                PangoLayout     *layout)
 {
   GList *l;
   GtkShadowElement *element;
 
+  if (!cairo_has_current_point (cr))
+    cairo_move_to (cr, 0, 0);
+
   /* render shadows starting from the last one,
    * and the others on top.
    */
@@ -274,10 +275,11 @@ _gtk_text_shadow_paint_layout (GtkShadow       *shadow,
 
       cairo_save (cr);
 
-      cairo_move_to (cr, x + element->hoffset, y + element->voffset);
+      cairo_rel_move_to (cr, element->hoffset, element->voffset);
       gdk_cairo_set_source_rgba (cr, &element->color);
       _gtk_pango_fill_layout (cr, layout);
 
+      cairo_rel_move_to (cr, -element->hoffset, -element->voffset);
       cairo_restore (cr);
   }
 }

diff --git a/gtk/gtkshadowprivate.h b/gtk/gtkshadowprivate.h
index 846b1d30fafaa85e780f908b8f3881c4cbd652b1..46ef0ffb199e4b5258ea3ecd6db3813689c31f04 100644 (file)
--- a/gtk/gtkshadowprivate.h
+++ b/gtk/gtkshadowprivate.h
@@ -55,8 +55,6 @@ gboolean   _gtk_shadow_get_resolved   (GtkShadow          *shadow);
 
 void       _gtk_text_shadow_paint_layout (GtkShadow       *shadow,
                                           cairo_t         *cr,
-                                          gdouble          x,
-                                          gdouble          y,
                                           PangoLayout     *layout);
 
 G_END_DECLS

diff --git a/gtk/gtkthemingengine.c b/gtk/gtkthemingengine.c
index 4ae5904a4b50ed5d7ec042340dc9b6a1d1e5f051..47833a3c08ab58d0f3d51b8858d8b03675cdbd61 100644 (file)
--- a/gtk/gtkthemingengine.c
+++ b/gtk/gtkthemingengine.c
@@ -2429,13 +2429,14 @@ gtk_theming_engine_render_layout (GtkThemingEngine *engine,
                           "text-shadow", &text_shadow,
                           NULL);
 
+  prepare_context_for_layout (cr, x, y, layout);
+
   if (text_shadow != NULL)
     {
-      _gtk_text_shadow_paint_layout (text_shadow, cr, x, y, layout);
+      _gtk_text_shadow_paint_layout (text_shadow, cr, layout);
       _gtk_shadow_unref (text_shadow);
     }
 
-  prepare_context_for_layout (cr, x, y, layout);
   gdk_cairo_set_source_rgba (cr, &fg_color);
   pango_cairo_show_layout (cr, layout);